Open
Conversation
…lt-in component fixes thegamenicorus#120
…component Update index.js
|
Thanks for writing this, the package it at least working now! |
|
Thx man, merged it into my fork and a bunch of other PRs as well. I'm thinking of maintaining that from now on. Will you be interested in helping out? |
|
@ravi-poonia Is your fork published? I would be happy to help out. I don't think the current maintainer will revisit this repo at all. |
|
I have published v1.0.0 and converted the source to typescript. Let me know if there is anything I can do to improve the change request process. Please submit new pull requests as the package as been more to https://github.com/rili-live/react-native-phone-input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this library, but when I installed it, I had a lot of problems
Picker was deprecated from react-native core repository
This pull was fixed picker problem, and I only added to readme that picker should be installed from
@react-native-community/pickerSome components have an issues with
Maximum update depth exceeded...to fix this issue update lib/countryPicker.js:
So I reworked it, added ability to use Country code or not via prop useCountryCode